Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 core] on_message_without_command dispatch #2338

Merged
merged 3 commits into from May 2, 2019
Merged

[V3 core] on_message_without_command dispatch #2338

merged 3 commits into from May 2, 2019

Conversation

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Dec 20, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Implements a new dispatch for messages which were not treated as a command.

Should reduce overhead compared to the current best method of each event generating a context for the message to check validity if they want to process commands differently to normal messages, while still handling both.

Kowlin
Kowlin approved these changes May 2, 2019
Copy link
Member

@Kowlin Kowlin left a comment

Works like a charm.

Loading

@mikeshardmind mikeshardmind merged commit 1699007 into Cog-Creators:V3/develop May 2, 2019
1 check passed
Loading
@mikeshardmind mikeshardmind deleted the non-command-dispatch branch May 2, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants