Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise setup.cfg, move version info to redbot package #2411

Merged
merged 4 commits into from Feb 9, 2019

Conversation

@Tobotimus
Copy link
Member

commented Feb 4, 2019

  • Setup metadata and options moved to setup.cfg. Since we no longer require arbitrary code execution in order to install reliably (no more compiler detection or platform-specific python_requires), we can move the options to the standardised setup.cfg for cleanliness and transparency.
  • redbot.__init__ now is safe to import without installing dependencies. Version info has also been moved here, so the version can now be retreived with redbot.__version__
  • Now deploying binary wheel distribution from travis, meaning faster and safer installs.
- `redbot.__init__` now is safe to import without installing dependencies.
- Now deploying binary wheel distribution from travis

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus Tobotimus force-pushed the Tobotimus:V3/clean_setup branch to 3655c72 Feb 4, 2019
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
setup.cfg Outdated Show resolved Hide resolved
Copy link
Member

left a comment

There is a remaining tag in Pypi that indicates that we're in beta.

Signed-off-by: Toby <tobyharradine@gmail.com>
@Tobotimus

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@Kowlin Thanks for reminding me, I just absentmindedly copied all of those over. I added some new ones as well.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus Tobotimus merged commit b9d440f into Cog-Creators:V3/develop Feb 9, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@Tobotimus Tobotimus deleted the Tobotimus:V3/clean_setup branch Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.