Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cooldown UX #2412

Merged
merged 2 commits into from Feb 18, 2019
Merged

improve cooldown UX #2412

merged 2 commits into from Feb 18, 2019

Conversation

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Feb 4, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This improves the feedback given on command_on_cool_down, as well as automatically handling cooldowns under 1 second for the user.

Copy link
Member

@aikaterna aikaterna left a comment

This works great. Thank you for adding this as I feel it really improves the user facing output. A small suggestion I have is putting a period at the end of the phrase so it looks more proper/complete (i.e. This command is on cooldown. Try again in 42 seconds.), but other than that this looks good.

Loading

@Tobotimus Tobotimus merged commit 722aaa2 into Cog-Creators:V3/develop Feb 18, 2019
1 check passed
Loading
@mikeshardmind mikeshardmind deleted the cooldown-feedback-improvement branch Dec 26, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants