Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod] Allow admin to choose amount of repeats for "deleterepeats" #2437

Merged
merged 4 commits into from Apr 23, 2019

Conversation

@jack1142
Copy link
Contributor

commented Feb 9, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This allows admin to set how many times message has to be repeated before deleterepeats removes it. (resolves #2267)

@jack1142 jack1142 requested a review from palmtree5 as a code owner Feb 9, 2019

@Tobotimus Tobotimus added this to the 3.1 Sprint 3 milestone Feb 27, 2019

@zephyrkul zephyrkul referenced this pull request Mar 1, 2019
2 of 18 tasks complete

@jack1142 jack1142 force-pushed the jack1142:V3/PR2267 branch Apr 21, 2019

@jack1142 jack1142 force-pushed the jack1142:V3/PR2267 branch to 17f14c8 Apr 21, 2019

@jack1142

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

There was a big change in structure of Mod since I created this PR, so it was easier to just apply it on V3/develop again, everything should be okay now 👍

redbot/cogs/mod/settings.py Outdated Show resolved Hide resolved
@jack1142

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

I changed what Sinbad asked for.

redbot/cogs/mod/settings.py Outdated Show resolved Hide resolved

jack1142 added some commits Apr 23, 2019

@jack1142

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Fixed what you asked for and also changed check to only fetch config, if guild's dict is not in cache yet.

@mikeshardmind mikeshardmind merged commit 460b4bb into Cog-Creators:V3/develop Apr 23, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

kennnyshiwa pushed a commit to kennnyshiwa/BB-8-Bot that referenced this pull request Apr 23, 2019

[Mod] Allow admins to choose amount of repeats for "deleterepeats" (C…
…og-Creators#2437)

* feat(mod): configurable amount of repeats for "deleterepeats"

resolves Cog-Creators#2267

* fix(mod): check user input instead of changing it if it's invalid

* fix(mod): only purge cache when argument is valid

* perf(mod): fetch repeats from config only when guild not in cache

jack1142 added a commit to jack1142/Red-DiscordBot that referenced this pull request Apr 24, 2019

tekulvw added a commit that referenced this pull request Apr 25, 2019

[Docs] Changelog entries for contributions by jack1142 (#2612)
* docs(changelog): [Mod] Allow admin to choose amount of repeats for "deleterepeats" #2437

* docs(changelog): Spelling correction of method name in Tunnel #2496

* docs(changelog): Tunnel fix - When tunnel closes, message should be sent to other end #2507

* docs(changelog): [V3 Downloader] Tell user how to load the cog after [p]cog install #2523

* docs(changelog): [V3 Audio] If bot has move members perm, it can join to user-limited channels #2525

* docs(changelog): [Trivia] Fix of dead image link (world flags) #2540

* docs(changelog): [V3 Test] Make sure that trivia test will use utf-8 encoding #2565

* docs(changelog): [V3 Core] Print actual version, when `--version` flag is used #2567

* docs(changelog): [V3 Downloader] Stop including subpackages in cog list #2590

* docs(changelog): [V3 Downloader] Uninstall multiple cogs #2592

* docs(changelog): [V3 Downloader] Always remove cog from installed in `[p]cog uninstall` #2595

@jack1142 jack1142 deleted the jack1142:V3/PR2267 branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.