Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Change pause to a toggle #2461

Merged
merged 1 commit into from Feb 18, 2019
Merged

[V3 Audio] Change pause to a toggle #2461

merged 1 commit into from Feb 18, 2019

Conversation

@aikaterna
Copy link
Member

@aikaterna aikaterna commented Feb 16, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Change pause to a toggle as it was confusing as an explicit alias for resume
  • Remove resume alias in preparation for removing other audio aliases, so owners can choose to assign their own aliases for audio commands instead of us dictating what they are
  • Added catch in stop command to stop and clear queue when a song is paused, as it would just silently do nothing previously if that was the player state
Copy link
Member

@TrustyJAID TrustyJAID left a comment

This works well after testing.

Loading

@Tobotimus Tobotimus merged commit 83411d0 into Cog-Creators:V3/develop Feb 18, 2019
1 check passed
Loading
@aikaterna aikaterna deleted the patch-4 branch Feb 18, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants