Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cooldown messages when expired #2469

Merged
merged 1 commit into from Apr 3, 2019
Merged

Conversation

@PredaaA
Copy link
Member

@PredaaA PredaaA commented Feb 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

It delete cooldown message when cooldown is expired to avoid having unnecessary messages in channels.

Note : It's a suggestion, personally I use it because it's a thing that was reported to me and finally I prefer like that.

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

👍

Loading

tekulvw
tekulvw approved these changes Apr 3, 2019
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Apr 3, 2019

For context, there was some discussion about adding this within the last set of changes to cooldown handling but needed discussion.

Loading

@tekulvw
Copy link
Member

@tekulvw tekulvw commented Apr 3, 2019

The "queued" build actually passed and the GH/Travis connection died.

Loading

@tekulvw tekulvw merged commit 82cda4b into Cog-Creators:V3/develop Apr 3, 2019
1 of 2 checks passed
Loading
@PredaaA PredaaA deleted the patch-4 branch Apr 7, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants