Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cooldown messages when expired #2469

Merged
merged 1 commit into from Apr 3, 2019

Conversation

@PredaaA
Copy link
Contributor

commented Feb 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

It delete cooldown message when cooldown is expired to avoid having unnecessary messages in channels.

Note : It's a suggestion, personally I use it because it's a thing that was reported to me and finally I prefer like that.

@mikeshardmind
Copy link
Member

left a comment

👍

@tekulvw

tekulvw approved these changes Apr 3, 2019

@mikeshardmind

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

For context, there was some discussion about adding this within the last set of changes to cooldown handling but needed discussion.

@tekulvw

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

The "queued" build actually passed and the GH/Travis connection died.

@tekulvw tekulvw merged commit 82cda4b into Cog-Creators:V3/develop Apr 3, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Created
Details
Travis CI - Pull Request Build Passed
Details

@PredaaA PredaaA deleted the PredaaA:patch-4 branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.