Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Add option for dc at queue end #2472

Merged
merged 5 commits into from Mar 4, 2019

Conversation

@aikaterna
Copy link
Member

commented Feb 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This addition adds a toggle for having the bot instantly disconnect when the queue ends. It takes precedence over the audioset emptydisconnect setting as it disconnects immediately when the queue or single song is finished.

@zephyrkul

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

Would it be possible to set this on a timer? Or would there not be much point to that

Edit: From a conversation on Discord: no

aikaterna added some commits Feb 27, 2019

@Tobotimus Tobotimus added this to the 3.1 Sprint 1 milestone Feb 27, 2019

@Tobotimus Tobotimus added QA: Needed and removed QA: Unassigned labels Feb 27, 2019

aikaterna added some commits Mar 3, 2019

@TrustyJAID
Copy link
Member

left a comment

Works great after testing.

@Tobotimus Tobotimus added QA: Passed and removed QA: Needed labels Mar 4, 2019

@Tobotimus Tobotimus merged commit 1503701 into Cog-Creators:V3/develop Mar 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@aikaterna aikaterna deleted the aikaterna:patch-4 branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.