Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Emptydisconnect and status refactor #2473

Merged
merged 3 commits into from Feb 22, 2019

Conversation

@aikaterna
Copy link
Member

commented Feb 20, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Refactored disconnect_timer, the function behind audioset emptydisconnect, to be more appropriately responsive (thanks to TrustyJAID)
  • Refactored status clearing/status changing when emptydisconnect or other Lavalink player statuses would have a TRACK_END event but no QUEUE_END event. This should clear or modify the bot's status event appropriately when [p]audioset status is on and the bot disconnects due to emptydisconnect and ideally play a little nicer with other cogs that set statuses.

aikaterna added some commits Feb 21, 2019

@TrustyJAID
Copy link
Member

left a comment

This is working as expected.

@Tobotimus Tobotimus added QA: Passed and removed QA: Needed labels Feb 22, 2019

@Tobotimus Tobotimus merged commit 7b9d85c into Cog-Creators:V3/develop Feb 22, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@aikaterna aikaterna referenced this pull request Feb 23, 2019
1 of 3 tasks complete

@aikaterna aikaterna deleted the aikaterna:patch-5 branch Feb 24, 2019

Tobotimus added a commit that referenced this pull request Mar 7, 2019

[Audio] Fix for audioset status (#2481)
Revert player.is_playing check added to the playing players list for audioset status in #2473. This addition would cause no status to be shown when a local track was played and skip was used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.