Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Fix for audioset status #2481

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@aikaterna
Copy link
Member

commented Feb 23, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Revert player.is_playing check added to the playing players list for audioset status in #2473. This addition would cause no status to be shown when a local track was played and skip was used.

@Tobotimus Tobotimus added the Type: Fix label Feb 24, 2019

@Tobotimus Tobotimus added this to the 3.1 Sprint 1 milestone Feb 27, 2019

@Tobotimus Tobotimus added QA: Passed and removed QA: Unassigned labels Mar 7, 2019

@Tobotimus Tobotimus merged commit 421043d into Cog-Creators:V3/develop Mar 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@aikaterna aikaterna deleted the aikaterna:patch-9 branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.