Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Spelling correction of method name in Tunnel #2496
mikeshardmind left a comment •
I'd prefer if this was done in a non-breaking fashion for now given how much QA has recommended people use this method when they need files in a quick and easy way.
@property def files_from_attatch(self): return self.files_from_attach
Adding this to the Tunnel class with your changes would be sufficient for that, the property could then be removed later on.
Because it is static method this would still be breaking change, because now you would have to create instance before using the method. I think it should be enough to just do a simple assignment to old name after defining the method.
files_from_attatch = files_from_attach
also, I wanted to add PR for this, because it looks like bad logic to me, this will always send the message to the side that started the tunnel, either original channel, or the sender that the bot reacts to on this channel - I think it should be:
send_to = self.recipient if uid == self.sender.id else self.origin
I just thought that maybe I could do it in this PR (assuming this isn't some strange logic that I just don't understand)