Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Match v2 behavior for channel change #2521

Merged
merged 3 commits into from Apr 3, 2019
Merged

[Audio] Match v2 behavior for channel change #2521

merged 3 commits into from Apr 3, 2019

Conversation

@aikaterna
Copy link
Member

@aikaterna aikaterna commented Mar 16, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

If the bot is not playing and there are no users in the channel with the bot(s), issuing an audio command should make the bot move to the new invoking channel. If the bot is playing something and a command is used where the invoker is in a different channel, the usual audio hierarchy will be used (mods can queue songs from outside of the channel, but the bot will stay put in the channel it's currently playing in, it will tell a pleb that they need to join the current channel, etc). Should match v2 audio behavior for this event.

Copy link
Member

@PredaaA PredaaA left a comment

I totally approve this PR. I have used it a lot (and I saw it has been used at several times on some servers), and for me it's working well as intented. Thanks for that, it's a useful feature!

Loading

tekulvw
tekulvw approved these changes Apr 3, 2019
@tekulvw tekulvw merged commit de7d08e into Cog-Creators:V3/develop Apr 3, 2019
1 check passed
Loading
@aikaterna aikaterna deleted the patch-4 branch Apr 3, 2019
@aikaterna aikaterna mentioned this pull request Jul 12, 2019
26 tasks
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants