Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] If bot has move members perm, it can join to user-limited channels #2525

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@jack1142
Copy link
Contributor

commented Mar 17, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Before this, when you wanted to play some music on full voice channel and bot had permission to move members (which allows you to join the user-limited channel) it wouldn't join and reply with "I don't have permission to connect to your channel." even though it could. This PR fixes this behavior.

I'm not sure if it was a right choice to not put this check in _userlimit method. I can change it, if you think it will be better this way.

@aikaterna

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Looks good and works as expected. For people reading this in the future if they are having problems making it work: make sure your bot has Read Text Channels & See Voice Channels checked, or if assigning the perm on the channel itself, View Channel, besides just the Move Members perm.

@tekulvw tekulvw removed the QA: Unassigned label Apr 9, 2019

@tekulvw tekulvw requested a review from aikaterna Apr 9, 2019

@tekulvw tekulvw merged commit e347ffa into Cog-Creators:V3/develop Apr 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jack1142 jack1142 deleted the jack1142:V3/audio-fix-permissions branch Apr 10, 2019

jack1142 added a commit to jack1142/Red-DiscordBot that referenced this pull request Apr 24, 2019

tekulvw added a commit that referenced this pull request Apr 25, 2019

[Docs] Changelog entries for contributions by jack1142 (#2612)
* docs(changelog): [Mod] Allow admin to choose amount of repeats for "deleterepeats" #2437

* docs(changelog): Spelling correction of method name in Tunnel #2496

* docs(changelog): Tunnel fix - When tunnel closes, message should be sent to other end #2507

* docs(changelog): [V3 Downloader] Tell user how to load the cog after [p]cog install #2523

* docs(changelog): [V3 Audio] If bot has move members perm, it can join to user-limited channels #2525

* docs(changelog): [Trivia] Fix of dead image link (world flags) #2540

* docs(changelog): [V3 Test] Make sure that trivia test will use utf-8 encoding #2565

* docs(changelog): [V3 Core] Print actual version, when `--version` flag is used #2567

* docs(changelog): [V3 Downloader] Stop including subpackages in cog list #2590

* docs(changelog): [V3 Downloader] Uninstall multiple cogs #2592

* docs(changelog): [V3 Downloader] Always remove cog from installed in `[p]cog uninstall` #2595
@aikaterna aikaterna referenced this pull request Jul 12, 2019
3 of 26 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.