Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[V3 Config] Require custom group initialization before usage #2545
Description of the changes
This is a breaking change when using Config's custom groups feature. In order to safely and effectively convert data between data backends we must know how to interpret custom groups. Prior to this PR that was impossible because we wouldn't know the length of the custom group's primary key. The primary key is the list of identifiers passed into
This PR adds the
mikeshardmind left a comment
Config objects need to be singletons with this change. The design direction this is going will require it here for some sanity instead of just at the driver.
Modification to object creation preferred over just the factory methods from me on this.
This also breaks the entire dataconverter cog. I'm fine with the removal of that cog until it can be rewritten in a more appropriate manner for future use.