Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Config] Record custom group information using cog_add event #2550

Merged
merged 6 commits into from Apr 10, 2019

Conversation

@tekulvw
Copy link
Member

commented Apr 4, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

No new breaking changes! This is an alternative to #2548. Blocked by #2545.

@tekulvw tekulvw force-pushed the tekulvw:V3/track_configs branch to bfea78f Apr 5, 2019

tekulvw added some commits Apr 5, 2019

@mikeshardmind
Copy link
Member

left a comment

This would be breaking a few existing approved cogs which make use of config objects with a different cog name for config than the actual cog name used for the help menu

If we had a secondary weakvalue dictionary for config objects which had already been accounted for, we can avoid this issue and just update any which haven't been already, adding entries to the dictionary storing the "last updated state"

@mikeshardmind
Copy link
Member

left a comment

👍 thanks for the changes, glad this one could avoid a breakage considering the required change that could end up being for 3rd party cog devs. Ready to go.

@Kowlin

Kowlin approved these changes Apr 10, 2019

@tekulvw tekulvw merged commit ba19179 into Cog-Creators:V3/develop Apr 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.