Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check to [p]set locale #2553

Merged
merged 3 commits into from Apr 23, 2019

Conversation

@Flame442
Copy link
Member

commented Apr 5, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #2552 by adding an explicit check as to whether or not locale_name is a valid locale.
I would like a little bit of feedback on this change.

  • Right now, locale_name is case sensitive. Should that remain case sensitive or should I allow it to accept it case insensitively?
  • I made the invalid locale string an i18n string, however I don't know the process for how those are supposed to be made or if that will break anything. Should that remain an i18n string or should I make it a normal string?
Adds a check to [p]set locale
Fixes #2552
I would like a little bit of feedback on this change.
- Right now, `locale_name` is case sensitive. Should that remain case sensitive or should I allow it to accept it case insensitively?
- I made the invalid locale string an i18n string, however I don't know the process for how those are supposed to be made or if that will break anything. Should that remain an i18n string or should I make it a normal string?

@Flame442 Flame442 requested a review from tekulvw as a code owner Apr 5, 2019

Flame442 added some commits Apr 23, 2019

Case insensitivity and explicit en-US
-`[p]set locale` is now case insensitive
-`en-US` added to `[p]listlocales` instead of only existing in `[p]set locale`'s help text

@tekulvw tekulvw merged commit 22c318f into Cog-Creators:V3/develop Apr 23, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

kennnyshiwa pushed a commit to kennnyshiwa/BB-8-Bot that referenced this pull request Apr 23, 2019

[Core] Adds a check to [p]set locale (Cog-Creators#2553)
* Adds a check to [p]set locale

Fixes Cog-Creators#2552
I would like a little bit of feedback on this change.
- Right now, `locale_name` is case sensitive. Should that remain case sensitive or should I allow it to accept it case insensitively?
- I made the invalid locale string an i18n string, however I don't know the process for how those are supposed to be made or if that will break anything. Should that remain an i18n string or should I make it a normal string?

* Case insensitivity and explicit en-US

-`[p]set locale` is now case insensitive
-`en-US` added to `[p]listlocales` instead of only existing in `[p]set locale`'s help text

* Remove spacing
@Flame442 Flame442 referenced this pull request May 3, 2019
1 of 3 tasks complete

@Flame442 Flame442 deleted the Flame442:patch-1 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.