Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check to [p]set locale #2553

Merged
merged 3 commits into from Apr 23, 2019
Merged

Adds a check to [p]set locale #2553

merged 3 commits into from Apr 23, 2019

Conversation

@Flame442
Copy link
Member

@Flame442 Flame442 commented Apr 5, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #2552 by adding an explicit check as to whether or not locale_name is a valid locale.
I would like a little bit of feedback on this change.

  • Right now, locale_name is case sensitive. Should that remain case sensitive or should I allow it to accept it case insensitively?
  • I made the invalid locale string an i18n string, however I don't know the process for how those are supposed to be made or if that will break anything. Should that remain an i18n string or should I make it a normal string?
Fixes #2552
I would like a little bit of feedback on this change.
- Right now, `locale_name` is case sensitive. Should that remain case sensitive or should I allow it to accept it case insensitively?
- I made the invalid locale string an i18n string, however I don't know the process for how those are supposed to be made or if that will break anything. Should that remain an i18n string or should I make it a normal string?
Flame442 added 2 commits Apr 23, 2019
-`[p]set locale` is now case insensitive
-`en-US` added to `[p]listlocales` instead of only existing in `[p]set locale`'s help text
@tekulvw tekulvw merged commit 22c318f into Cog-Creators:V3/develop Apr 23, 2019
1 check passed
Loading
@Flame442 Flame442 deleted the patch-1 branch May 7, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants