Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Setup] Overhaul backend conversion process through setup scripts #2579

Merged
merged 27 commits into from Apr 21, 2019

Conversation

@tekulvw
Copy link
Member

commented Apr 13, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

There's a lot. I'll list the stuff when I'm done.

@tekulvw tekulvw force-pushed the tekulvw:V3/click_setup branch to 00399cb Apr 13, 2019

@tekulvw tekulvw removed the QA: Unassigned label Apr 20, 2019

tekulvw added some commits Apr 20, 2019

@@ -49,6 +49,10 @@ def __init__(self, cog_name, identifier, **kwargs):
if _conn is None:
_initialize(**kwargs)

async def has_valid_connection(self) -> bool:
# Maybe fix this?

This comment has been minimized.

Copy link
@mikeshardmind

mikeshardmind Apr 20, 2019

Member

Probably doesn't need fixing. With mongo selected, if there isn't a valid connection, the bot hangs prior to connect waiting for a token it wont get from mongo.

@mikeshardmind mikeshardmind merged commit 6c296a9 into Cog-Creators:V3/develop Apr 21, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.