Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Setup] Overhaul backend conversion process through setup scripts #2579

Merged
merged 27 commits into from Apr 21, 2019

Conversation

@tekulvw
Copy link
Member

@tekulvw tekulvw commented Apr 13, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

There's a lot. I'll list the stuff when I'm done.

@tekulvw tekulvw force-pushed the V3/click_setup branch from df35c53 to 00399cb Apr 13, 2019
@@ -49,6 +49,10 @@ def __init__(self, cog_name, identifier, **kwargs):
if _conn is None:
_initialize(**kwargs)

async def has_valid_connection(self) -> bool:
# Maybe fix this?
Copy link
Contributor

@mikeshardmind mikeshardmind Apr 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably doesn't need fixing. With mongo selected, if there isn't a valid connection, the bot hangs prior to connect waiting for a token it wont get from mongo.

@mikeshardmind mikeshardmind merged commit 6c296a9 into Cog-Creators:V3/develop Apr 21, 2019
1 check passed
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants