Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord.py dep update 3.1 #2587

Merged

Conversation

@mikeshardmind
Copy link
Member

commented Apr 17, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This puts our discord.py version at 1.0.1, incorporates a lot of breaking changes which need an announcement, and remove our prior need of vendoring discord.py now that there's a release on pypi.

This also (temporarily) reverts to using discord.py's base help formatter

@mikeshardmind mikeshardmind added this to the 3.1 Sprint 2 milestone Apr 17, 2019

@mikeshardmind mikeshardmind force-pushed the mikeshardmind:discord.py-dep-update-3.1 branch Apr 17, 2019

@mikeshardmind mikeshardmind marked this pull request as ready for review Apr 17, 2019

@mikeshardmind

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

I've verified the behaviors I expect with this to work, do in fact work.

Depending on how soon we want to make these changes available to cog creators, this can be merged with our without the helpformatter support ready.

There should not be a developer facing change to how i18n will function with the helpformatter.

This requires a large list of breaking changes to be published in our 3.1 release notes.

@mikeshardmind mikeshardmind force-pushed the mikeshardmind:discord.py-dep-update-3.1 branch 2 times, most recently Apr 17, 2019

@mikeshardmind

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

Noticed a few more issues with this, more changes needed.

@mikeshardmind mikeshardmind force-pushed the mikeshardmind:discord.py-dep-update-3.1 branch 3 times, most recently Apr 18, 2019

Dependency update
discord.py==1.0.1
websockets<7

[style]
black==19.3b0

[Docs]
jinja==2.10.1
urllib3==1.24.2

Changes related to breraking changes from discord.py have also been made
to match

As of this commit, help formatter is back to discord.py's default and
i18n support in help is broken

@mikeshardmind mikeshardmind force-pushed the mikeshardmind:discord.py-dep-update-3.1 branch to 4d4b4e1 Apr 20, 2019

@zephyrkul zephyrkul referenced this pull request Apr 22, 2019
1 of 3 tasks complete

@mikeshardmind mikeshardmind merged commit ad11429 into Cog-Creators:V3/develop Apr 24, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

mikeshardmind added a commit to mikeshardmind/Red-DiscordBot that referenced this pull request Apr 24, 2019

tekulvw added a commit that referenced this pull request Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.