Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Track search and append fixes #2591

Merged
merged 2 commits into from Apr 22, 2019
Merged

[Audio] Track search and append fixes #2591

merged 2 commits into from Apr 22, 2019

Conversation

@aikaterna
Copy link
Member

@aikaterna aikaterna commented Apr 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Tracks had ytsearch: appended to it twice in some searching situations, accidentally introduced in the Spotify PR (#2328)
  • Playlist append was joining strings with spaces in some situations before searching
@@ -1183,7 +1183,11 @@ def _restart_connect(self):
player = lavalink.get_player(ctx.guild.id)
guild_data = await self.config.guild(ctx.guild).all()
if type(query) is not list:
if not (query.startswith("http") or query.startswith("localtracks")):
if not (
Copy link

@Nodja Nodja Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pass a tuple to startswith:

if not query.startswith(("http", "localtracks", "ytsearch"))

Loading

@tekulvw tekulvw merged commit bb8ce43 into Cog-Creators:V3/develop Apr 22, 2019
1 check passed
Loading
@aikaterna aikaterna deleted the patch-12 branch Aug 1, 2019
@jack1142 jack1142 added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants