Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Track search and append fixes #2591

Merged
merged 2 commits into from Apr 22, 2019

Conversation

@aikaterna
Copy link
Member

commented Apr 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Tracks had ytsearch: appended to it twice in some searching situations, accidentally introduced in the Spotify PR (#2328)
  • Playlist append was joining strings with spaces in some situations before searching
@@ -1183,7 +1183,11 @@ def _restart_connect(self):
player = lavalink.get_player(ctx.guild.id)
guild_data = await self.config.guild(ctx.guild).all()
if type(query) is not list:
if not (query.startswith("http") or query.startswith("localtracks")):
if not (

This comment has been minimized.

Copy link
@Nodja

Nodja Apr 19, 2019

You can pass a tuple to startswith:

if not query.startswith(("http", "localtracks", "ytsearch"))

@tekulvw tekulvw merged commit bb8ce43 into Cog-Creators:V3/develop Apr 22, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@aikaterna aikaterna deleted the aikaterna:patch-12 branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.