Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Downloader] Allow to specify minimum and maximum bot version in info.json #2605

Merged
merged 3 commits into from Apr 29, 2019

Conversation

@jack1142
Copy link
Contributor

commented Apr 23, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds actually working way of specifying minimum and maximum bot version and removes not working bot_version key in info.json file
Downloader won't allow to install a cog if it doesn't support current version of Red.

However it's not checked at all during cog update (and neither is minimum python version in that matter) I would like to do this in separate PR, preferably after #2571 as it has whole cog update process improved a lot and it might be easier to write with use of those changes.

Also, shared libraries aren't checked for both python and bot version anywhere either, but again, it will be easier to do this with use of that rewritten code from #2571.

BREAKING CHANGE:

  • removal of bot_version attribute in Installable
  • cog developers have to use min_bot_version instead of bot_version (bot_version didn't actually work, but still they need to know that)

@jack1142 jack1142 requested review from palmtree5 and tekulvw as code owners Apr 23, 2019

@jack1142 jack1142 requested a review from Twentysix26 as a code owner Apr 23, 2019

jack1142 added some commits Apr 23, 2019

feat(downloader): add `min_bot_version` and `max_bot_version`
Adds actually working way of specifying minimum and maximum bot version and removes not working
`bot_version`

BREAKING CHANGE: - removal of `bot_version` attribute in `Installable`

@jack1142 jack1142 force-pushed the jack1142:V3/check_version branch to a776ce1 Apr 25, 2019

@jack1142

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Added changelog entries to this PR.

@mikeshardmind mikeshardmind merged commit 24ac111 into Cog-Creators:V3/develop Apr 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jack1142 jack1142 deleted the jack1142:V3/check_version branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.