Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default locale value to `en-US` #2642

Merged
merged 3 commits into from May 6, 2019

Conversation

@Flame442
Copy link
Member

commented May 3, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

The default locale was previously en. With the check added to [p]set locale in #2553, en is technically an invalid locale (it still works, but it isn't one that is supposed to be used).
This fixes that issue by setting the default locale to en-US, which is a locale that is able to be set with [p]set locale and the locale recommended by the help text of [p]set locale to change back to English.

Fixes #2641

@Flame442 Flame442 requested a review from Twentysix26 as a code owner May 3, 2019

Added this PR
Also fixed slight inconsistency in what is in a code block (if this is merged)

@Flame442 Flame442 requested review from palmtree5 and tekulvw as code owners May 3, 2019

@mikeshardmind mikeshardmind merged commit 4f6485d into Cog-Creators:V3/develop May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@Flame442 Flame442 deleted the Flame442:patch-4 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.