Config locks #2654
Merged
Config locks #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
# Conflicts: # redbot/core/config.py
…scordBot into V3/config_locks
Signed-off-by: Toby <tobyharradine@gmail.com>
mikeshardmind
suggested changes
Jul 19, 2019
This needs some work...
(This has a registered channel : channels={}, was being lazy)
(gotta love how the __getattr__ continues to bite us)
However, there's another issue as well with this:
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
approved these changes
Jul 23, 2019
I've not found any other issues. I also looked through (did not manually test each of) the other places we already use config as a context manager to see if I could spot anywhere this might turn into a deadlock which wasn't before (though this would have indicated that section was problematic for the things this aims to help mitigate) and didn't spot any.
Definitely want to see if we can get this onto some of our larger ambassador bots without issue for testing if we have willing victims participants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This provides a way to lock by individual value, at any level of the config hierarchy desired.
Uses a weakref dictionary to maintain locks across multiple
Valueobjects whilst they're simultaneously alive.This also updates the
async with config.foo()context manager to use thefoovalue's lock, unless a newacquire_lockkwarg is set toFalsefor some edge case where acquiring the lock is undesirable.