Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve automated checks #2702

Merged
merged 10 commits into from Jun 2, 2019
Merged

[CI] Improve automated checks #2702

merged 10 commits into from Jun 2, 2019

Conversation

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented May 18, 2019

This immediately caught several things we have open PRs for, as well as
some which we do not.

  • This leverages pylint
  • This includes a .pylintrc with some very specific things already
    disabled, including entire categories in a few cases
  • closes #2644
  • This adds a few specific exceptions where known spurious
  • This includes a few small changes to remove minor issues

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This should reduce the chances of uncaught issues. This can't be merged prior to specific things being fixed. (see: #2699 , #2676 , #2686 )

@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented May 19, 2019

This is ready to go, but blocked by an error newly caught by the new CI config to be fixed in #2688

@mikeshardmind mikeshardmind added this to the 3.1.2 milestone May 23, 2019
@mikeshardmind mikeshardmind removed this from the 3.1.2 milestone May 31, 2019
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone May 31, 2019
@mikeshardmind mikeshardmind requested a review from Kowlin Jun 1, 2019
Kowlin
Kowlin approved these changes Jun 2, 2019
@Kowlin Kowlin merged commit 16443c8 into Cog-Creators:V3/develop Jun 2, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the use-pylint branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants