Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve automated checks #2702

Merged
merged 10 commits into from Jun 2, 2019

Conversation

@mikeshardmind
Copy link
Member

commented May 18, 2019

This immediately caught several things we have open PRs for, as well as
some which we do not.

  • This leverages pylint
  • This includes a .pylintrc with some very specific things already
    disabled, including entire categories in a few cases
  • closes #2644
  • This adds a few specific exceptions where known spurious
  • This includes a few small changes to remove minor issues

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This should reduce the chances of uncaught issues. This can't be merged prior to specific things being fixed. (see: #2699 , #2676 , #2686 )

@mikeshardmind

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

This is ready to go, but blocked by an error newly caught by the new CI config to be fixed in #2688

@mikeshardmind mikeshardmind added this to the 3.1.2 milestone May 23, 2019
@mikeshardmind mikeshardmind modified the milestones: 3.1.2, 3.1.3 May 31, 2019
@mikeshardmind mikeshardmind force-pushed the mikeshardmind:use-pylint branch from 84f96d7 to 05794d6 Jun 1, 2019
@mikeshardmind mikeshardmind requested a review from Kowlin Jun 1, 2019
@Kowlin
Kowlin approved these changes Jun 2, 2019
@Kowlin Kowlin merged commit 16443c8 into Cog-Creators:V3/develop Jun 2, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.