Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Economy] House always wins in slots #2875

Merged
merged 4 commits into from Aug 27, 2019
Merged

[Economy] House always wins in slots #2875

merged 4 commits into from Aug 27, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jul 15, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • Expected payout % is under 100%
  • No flat increase payouts, all payouts are multiplicative

This kills (some of) the inflation in economy.

@mikeshardmind mikeshardmind requested a review from palmtree5 as a code owner Jul 15, 2019
@Tobotimus Tobotimus added the Type: Enhancement label Jul 15, 2019
@Flame442 Flame442 added the Changelog Entry: Pending label Aug 27, 2019
@Flame442 Flame442 assigned Flame442 and unassigned aikaterna Aug 27, 2019
Copy link
Member

@Flame442 Flame442 left a comment

Expected return is 62.5%. The only thing I'd like fixed (as discussed in discord) is the payout needs to be a bit more clear now that the bet is still subtracted on win.

Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Changes requested by Flame#2941

@Flame442 Flame442 added QA: Changes Requested and removed QA: Needed labels Aug 27, 2019
Michael H added 3 commits Aug 27, 2019
 - Expected payout is negative
 - No flat increase payouts, all payouts are multiplicative
@mikeshardmind mikeshardmind requested a review from Twentysix26 as a code owner Aug 27, 2019
@mikeshardmind mikeshardmind requested a review from Flame442 Aug 27, 2019
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@Flame442 Flame442 added QA: Passed and removed Changelog Entry: Pending QA: Changes Requested labels Aug 27, 2019
@mikeshardmind mikeshardmind merged commit 68018c9 into Cog-Creators:V3/develop Aug 27, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the slots-odds branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants