Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowmode now accepts integer only inputs as seconds #2884

Merged
merged 3 commits into from Jul 17, 2019

Conversation

DevilXD
Copy link
Contributor

@DevilXD DevilXD commented Jul 17, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

The [p]slowmode command now accepts integer only values as seconds.
Instead of doing [p]slowmode 10s one can do [p]slowmode 10 for the same effect as well.

@DevilXD DevilXD requested a review from palmtree5 as a code owner Jul 17, 2019
@DevilXD
Copy link
Contributor Author

@DevilXD DevilXD commented Jul 17, 2019

Hmm, so apparently Travis failed on docs only because of the new changelog stuff. Note that this PR doesn't even touch docs, so hopefully it should be good regardless .-.

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jul 17, 2019

Needa a changelog entry. I think Github should have prompted that the contribution guidelines were updated.since.your last PR.

@DevilXD DevilXD requested a review from Twentysix26 as a code owner Jul 17, 2019
@DevilXD
Copy link
Contributor Author

@DevilXD DevilXD commented Jul 17, 2019

Didn't know this. Should be alright now I guess

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

👍

@mikeshardmind mikeshardmind merged commit 0ba9eae into Cog-Creators:V3/develop Jul 17, 2019
1 check passed
@DevilXD DevilXD deleted the slowmode-default-unit branch Jul 17, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants