Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled help hideaways #2892

Merged
merged 2 commits into from Jul 27, 2019
Merged

disabled help hideaways #2892

merged 2 commits into from Jul 27, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jul 19, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • fixes #2863
  • Also removes the warning about the help formatter's API changing.

@mikeshardmind mikeshardmind requested a review from Twentysix26 as a code owner Jul 19, 2019
redbot/core/commands/help.py Outdated Show resolved Hide resolved
Copy link
Member

@Flame442 Flame442 left a comment

This works as intended now.

@@ -0,0 +1 @@
``Command.can_see`` now works as intended for disabled commands
Copy link
Member

@Flame442 Flame442 Jul 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nitpicking, but this doesn't have a period.

Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@Flame442 Flame442 added QA: Passed and removed QA: Needed labels Jul 27, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jul 27, 2019
@mikeshardmind mikeshardmind merged commit 6280fd9 into Cog-Creators:V3/develop Jul 27, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the disabled-com-help-fix branch Jul 27, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants