New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove commas for explanations about how to set API keys in concerned cogs #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old comma separation does still work, however it may be phased out in the future. For consistency's sake, imgurcreds in the image cog should also be updated. |
@Flame442 Done, I updated imgurcreds and giphycreds. Also edited my PR comment to include image cog. |
-Replaced in line code blocks with italics -Removed []() link formatting (for when embeds are disabled) -Added a period to the doc string -Added periods at the end of each line -"Run the command" instead of "Do" for clarity -"your_api_key_here" instead of "your_api_key" for consistency
Changes from Cog-Creators#2729 and Cog-Creators#2733
Flame442
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
QA: Passed
Used by few QA members. Has been approved by the assigned QA member(s).
Type: Bug
Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Type
Description of the changes
This PR removes commas in explanations about how to set API keys in streams, image and audio cogs, since it has been changed in #2692.