Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commas for explanations about how to set API keys in concerned cogs #2905

Merged
merged 10 commits into from Aug 17, 2019

Conversation

PredaaA
Copy link
Member

@PredaaA PredaaA commented Jul 27, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR removes commas in explanations about how to set API keys in streams, image and audio cogs, since it has been changed in #2692.

@Flame442
Copy link
Member

@Flame442 Flame442 commented Jul 27, 2019

The old comma separation does still work, however it may be phased out in the future.

For consistency's sake, imgurcreds in the image cog should also be updated.

@PredaaA PredaaA changed the title Remove commas for explanations about how to set API keys Remove commas for explanations about how to set API keys in concerned cogs Jul 27, 2019
@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Jul 27, 2019

@Flame442 Done, I updated imgurcreds and giphycreds. Also edited my PR comment to include image cog.

Flame442 and others added 3 commits Jul 27, 2019
-Replaced in line code blocks with italics
-Removed []() link formatting (for when embeds are disabled)
-Added a period to the doc string
-Added periods at the end of each line
-"Run the command" instead of "Do" for clarity
-"your_api_key_here" instead of "your_api_key" for consistency
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@Flame442 Flame442 added the QA: Passed label Jul 27, 2019
@Flame442 Flame442 self-assigned this Jul 27, 2019
@Tobotimus Tobotimus merged commit 3498f8c into Cog-Creators:V3/develop Aug 17, 2019
1 check passed
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Aug 30, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants