[ModLog] Optimise get_next_case_number() #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Tobotimus
added
the
Type: Optimisation
mikeshardmind
suggested changes
Jul 30, 2019
mikeshardmind
added
the
Changelog Entry: Pending
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
suggested changes
Jul 31, 2019
one last change from me after some consideration.
Let's go ahead and make get_next_case_number private and remove it from __all__
There's not a reason to expose this function outside of modlog, and the next release is one which allows for removing this from the public API.
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
|
@mikeshardmind I've actually gone ahead and removed the function all together. It was only used in one place, and that place is kind of easier to understand (w.r.t. lock usage) if it just uses config directly. |
mikeshardmind
previously approved these changes
Jul 31, 2019
mikeshardmind
dismissed
their stale review
Apparently it *isn't the only place (discussion: discord)
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
approved these changes
Aug 2, 2019
mikeshardmind
removed
the
Changelog Entry: Pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We've noticed that this is taking an obscenely long time on very large servers.