Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small docstring inconsistency #2924

Merged
merged 3 commits into from Aug 27, 2019
Merged

Conversation

DevilXD
Copy link
Contributor

@DevilXD DevilXD commented Aug 8, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Noticed a small inconsistency where the docs say about raising a KeyError, but the class actually raises a TypeError. This PR changes the docs to match the code (rather than change the code to match the docs, which could break things).

@DevilXD DevilXD requested a review from mikeshardmind as a code owner Aug 8, 2019
@DevilXD DevilXD requested a review from Twentysix26 as a code owner Aug 8, 2019
@Flame442 Flame442 added Category: Docs Type: Fix labels Aug 9, 2019
changelog.d/2924.bugfix.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Changes requested by Flame#2941

@Flame442 Flame442 self-assigned this Aug 27, 2019
@Flame442 Flame442 added the QA: Changes Requested label Aug 27, 2019
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@mikeshardmind mikeshardmind merged commit bbd3041 into Cog-Creators:V3/develop Aug 27, 2019
1 check passed
@DevilXD DevilXD deleted the patch-1 branch Aug 29, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Aug 30, 2019
@Flame442 Flame442 added QA: Passed and removed QA: Changes Requested labels Aug 30, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs QA: Passed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants