Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Various fixes to redbot-setup delete #2958

Merged
merged 8 commits into from Aug 29, 2019

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Aug 28, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • redbot-setup delete no longer errors about "unexpected keyword argument" (fix #2955)
  • redbot-setup delete no longer prompts about backup when user passes --no-prompt option (fix #2956)
  • --[no-]backup, --[no-]drop-db and --[no-]remove-datapath in redbot-setup delete command are now on/off flags. --no-prompt was changed to flag too, but it doesn't have --prompt equivalent as there's no much point in having it
  • redbot-setup now uses click.confirm for confirmation prompts and thy now also have default values for user convenience

@Tobotimus Tobotimus added the Type: Enhancement label Aug 29, 2019
@Tobotimus Tobotimus merged commit b490942 into Cog-Creators:V3/develop Aug 29, 2019
1 check passed
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Aug 30, 2019
@jack1142 jack1142 deleted the V3/setup_fixes branch Aug 30, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants