Fix issues with embed_requested()

[DJtheRedstoner]

Type

• Bugfix
• Enhancement
• New feature

Description of the changes

Remove if statement that causes embed_requested() not to always return the correct user set value.

[Tobotimus]

This will break embed_requested() in DMs, because PrivateChannels don't have a guild attribute.

The current behaviour is that the guild setting takes priority over the user setting, and as far as I can tell, this behaviour is intended. Perhaps we should open up a discussion on whether the embed setting should be personalised, or whether the guild setting should take priority?

[DJtheRedstoner]

What does need to be fixed is that the user setting should always affect help but only affects help run with [p]help and not help sent by other commands

[mikeshardmind]

What does need to be fixed is that the user setting should always affect help but only affects help run with [p]help and not help sent by other commands

I can't replicate the described issue. ctx.send_help() sent from a command actually invokes the same exact help logic as running [p]help commandname as a command with respect to the embed setting. (they both call: ctx.bot.send_help_for with the context preserved)

[DJtheRedstoner]

It only works in a guild channel.

[mikeshardmind]

As Toby said,

The current behaviour is that the guild setting takes priority over the user setting, and as far as I can tell, this behaviour is intended. Perhaps we should open up a discussion on whether the embed setting should be personalised, or whether the guild setting should take priority?

Above image shows this, but these changes don't adequately handle this.

I'm also not sure we should change the priority here. Guild owners have a reason to expect help to look consistent within their own server.

[DJtheRedstoner]

I did not realize that the intended behaviour was guild having priority over user, but it does not make sense to me why user should only have priority over guild in help (and there IS a bug with this).

Is the intended priority Guild > User > Global?

My suggestion is to make the user setting ONLY apply in DM's

[mikeshardmind]

Much more acceptable way to handle this.

stale