Fixed crash originated in bank.set_balance
#2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[p]bankset maxbal` can be used to set the maximum bank balance Signed-off-by: Guy <guyreis96@gmail.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
|
If this is fixing a bug introduced in dev, the changelog should probably be |
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Flame442
requested changes
Sep 18, 2019
The two functions affected by this change need to have their docstrings and typehints updated accordingly. Both now accept Union[discord.Member, discord.User] and both now raise RuntimeError (from the get_s they use) when a user is passed and the bank is server based.
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
|
All sorted, thanks for the review Flame! |
|
The wording of the RuntimeError's description "guild was not provided" makes it seems like there should be a way to pass a guild to the functions. This should be changed to something that references how a user was used and a member is required. |
Signed-off-by: guyre <27962761+drapersniper@users.noreply.github.com>
Flame442
approved these changes
Sep 20, 2019
Flame442
added
the
QA: Passed
jack1142
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Type
Description of the changes
Fixed crash seen in DM when calling
bank.set_balancewhich was introduced in #2926