Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Git Install Updates, note about launcher deprecation, capitalise some words #2998

Merged
merged 4 commits into from Sep 29, 2019

Conversation

Vexed01
Copy link
Contributor

@Vexed01 Vexed01 commented Sep 13, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Git updated the title they gave to the add to PATH option during setup for Windows from "Run Git from the Windows Command Prompt" to "Git from the command line and also from 3rd-party software", as we found out in #support. I have also checked this is correct.
This PR also corrects some capitalisation and a note about launcher deprecation.

@Vexed01 Vexed01 changed the title commit commit of awesomeness Sep 13, 2019
@Vexed01 Vexed01 changed the title commit of awesomeness [Docs] Update Git PATH install (Windows) and capitalise some words Sep 13, 2019
@Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Sep 13, 2019

"Please note the launcher will be deprecated soon." if this is indeed being added here, shoudln't we add it to the Mac and Linux docs ? given that this change will not be specific to windows

@Vexed01
Copy link
Contributor Author

@Vexed01 Vexed01 commented Sep 13, 2019

"Please note the launcher will be deprecated soon." if this is indeed being added here, shoudln't we add it to the Mac and Linux docs ? given that this change will not be specific to windows

Good point, thanks for pointing out what my small brain cannot comprehend.

Vexed01 added 2 commits Sep 13, 2019
capitalise some linix stuff i couldnt be bothered to do before
@Vexed01 Vexed01 changed the title [Docs] Update Git PATH install (Windows) and capitalise some words [Docs] Git Install Updates, note about launcher deprecation, capitalise some words Sep 13, 2019
@Flame442 Flame442 added Category: Docs Type: Fix labels Sep 18, 2019
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

While we are looking to remove the launcher, it's better to guide users away from it by not directing them to use it than to say "It's deprecated" when we haven't even decided on if removing it is in the cards, or if we should just be minimizing the code which lives in it.

@Vexed01
Copy link
Contributor Author

@Vexed01 Vexed01 commented Sep 29, 2019

I think this is what you mean, you haven't clearly said exactly what changes you want.

@Vexed01 Vexed01 requested a review from mikeshardmind Sep 29, 2019
@mikeshardmind mikeshardmind merged commit 37f27d8 into Cog-Creators:V3/develop Sep 29, 2019
1 check passed
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Sep 29, 2019
@Vexed01 Vexed01 deleted the docs-patch branch Sep 29, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants