Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uptime for uptime of less than a second #3009

Merged
merged 3 commits into from Sep 28, 2019
Merged

fix uptime for uptime of less than a second #3009

merged 3 commits into from Sep 28, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Sep 21, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Yes, I'm aware this is an edge case.

@@ -326,9 +326,10 @@ class Core(commands.Cog, CoreLogic):
"""Shows Red's uptime"""
since = ctx.bot.uptime.strftime("%Y-%m-%d %H:%M:%S")
Copy link
Member

@Flame442 Flame442 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be bot._uptime now

Copy link
Contributor Author

@mikeshardmind mikeshardmind Sep 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this one was left available as a property which only errors if you try to assign to it.

Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Changes requested by Flame#2941

@Flame442 Flame442 added the QA: Changes Requested label Sep 27, 2019
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@Flame442 Flame442 added QA: Passed and removed QA: Changes Requested labels Sep 28, 2019
@mikeshardmind mikeshardmind merged commit e38c08a into Cog-Creators:V3/develop Sep 28, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the another-uptime-fix branch Sep 28, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants