Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the hierarchy issue messages #3016

Merged
merged 4 commits into from Sep 27, 2019
Merged

Change the hierarchy issue messages #3016

merged 4 commits into from Sep 27, 2019

Conversation

RealFriesi
Copy link

@RealFriesi RealFriesi commented Sep 26, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Add custom messages for adding and removing roles. This removed the verb variable which makes it difficult to translate the messages.

because they are difficult to translate with the verb variable.
@RealFriesi RealFriesi requested a review from tekulvw as a code owner Sep 26, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Sep 26, 2019
@mikeshardmind mikeshardmind added Changelog Entry: Pending Type: Enhancement labels Sep 26, 2019
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Thanks! Changes like this to support i18n better are good to have.

If you can toss a brief changelog entry into this PR, we'll get it merged in.

If anything is unclear about the process there, please ask.

Copy link
Member

@Flame442 Flame442 left a comment

I know that these issues are not a result of your changes, but they should still be fixed regardless. Thank you for contributing.

USER_HIERARCHY_ISSUE = _(
"I tried to {verb} {role.name} to {member.display_name} but that role"
HIERARCHY_ISSUE_REMOVE = _(
"I tried to remove {role.name} to {member.display_name} but that role"
Copy link
Member

@Flame442 Flame442 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrase should be "I tried to remove {role.name} from ..."

HIERARCHY_ISSUE_REMOVE = _(
"I tried to remove {role.name} to {member.display_name} but that role"
" is higher than my highest role in the Discord hierarchy so I was"
" unable to successfully add it. Please give me a higher role and "
Copy link
Member

@Flame442 Flame442 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrase should be "unable to successfully remove it."

)

USER_HIERARCHY_ISSUE_REMOVE = _(
"I tried to remove {role.name} to {member.display_name} but that role"
Copy link
Member

@Flame442 Flame442 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above, "from" and "remove".

@RealFriesi RealFriesi requested a review from Twentysix26 as a code owner Sep 27, 2019
@RealFriesi
Copy link
Author

@RealFriesi RealFriesi commented Sep 27, 2019

I think I did everything right now :D

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Looks solid, thanks!

@mikeshardmind mikeshardmind merged commit 101e977 into Cog-Creators:V3/develop Sep 27, 2019
1 check passed
@Flame442 Flame442 removed the Changelog Entry: Pending label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants