Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streams] Fix TypeError in TwitchStream class and change stream_alert function for Twitch #3042

Merged
merged 5 commits into from Jan 3, 2020

Conversation

PredaaA
Copy link
Member

@PredaaA PredaaA commented Oct 9, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR fix a TypeError in TwitchStream class when calling Twitch client_id from Red shared APIs tokens and also changed the stream_alert function for Twitch alerts to make it works with how TwitchStream class works now.

@PredaaA PredaaA changed the title [Streams] Fix TypeError in TwitchStream class [Streams] Fix TypeError in TwitchStream class and change stream_alert function for Twitch Oct 10, 2019
@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Oct 10, 2019

I just updated my PR for Twitch streams alert. The first commit was making impossible to set a Twitch alert and also alerts was no longer sent. I changed the stream_alert function in streams.py to make it get the client_id instead of the whole dict.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Oct 13, 2019
@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Oct 19, 2019

This PR can't be merged for now because there's a new issue with it. Once a stream alert for a specific channel has been sent, they are no longer sent after. Also as what I seen when looking into this issue, the _messages_cache defined in self.streams and set at load_streams and check_streams functions, is no longer cleared when a stream goes offline while it is the intention here.

@mikeshardmind mikeshardmind added the Blocked By: Damage Control label Oct 19, 2019
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Oct 19, 2019

Thanks for the update. I'm marking this as blocked then, when it's ready let us know.

@mikeshardmind mikeshardmind added the Release Blocker label Nov 26, 2019
@mikeshardmind mikeshardmind removed the Blocked By: Damage Control label Jan 3, 2020
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jan 3, 2020

Unblocking this, the TypeError is a fix, but the other noticed issue pre-exists and isn't caused by this, fix is good to go.

@mikeshardmind mikeshardmind merged commit 743ce71 into Cog-Creators:V3/develop Jan 3, 2020
1 check passed
@PredaaA PredaaA deleted the patch-6 branch Jan 3, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants