Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[Core] Add `redbot --edit` cli flag (replacement for `[p]set owner&token`) #3060
Conversation
jack1142
changed the title
This comment has been minimized.
This comment has been minimized.
Malarne
commented
Oct 19, 2019
|
After a bit of testing, a keyboard interrupt throws this error: |
This comment has been minimized.
This comment has been minimized.
|
This is now ready for review, I updated the PR description accordingly. |
jack1142
changed the title
|
Changes requested by Flame#2941 |
|
Works fine, can't break it. |
mikeshardmind
merged commit 1651de1
into
Cog-Creators:V3/develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jack1142 commentedOct 15, 2019
•
edited
Type
Description of the changes
This PR adds
redbot --editcli flag that allows to edit instance name, token, owner and datapath. It's supposed to be a replacement for[p]set ownerand[p]set tokenthat were removed due to being potentially dangerous.I used the occasion to unify all confirmation prompts in Red's cli commands and also fixed a small bug that allowed user to pass no arguments to
--co-ownerand--load-cogsFlags that can be used with
redbot --edit:--no-prompt- disables everything interactive in the command, if it's not passed the command will ask for everything that wasn't passed with other flags--token- can be used to change token--owner- can be used to change owner--edit-instance-name- can be used to change instance name--overwrite-existing-instance- can be used with--edit-instance-nameto allow Red to overwrite existing instance when changing name--edit-data-path- can be used to change data path--copy-data- can be used with--edit-data-pathto make Red copy data from old data path to new oneThis might be considered breaking as I did change function signature for
confirm()andinteractive_config()that are underredbot.core.climodule but I didn't make changelog entries for that and I'm waiting for response whether I should add changelog entries, make this change non-breaking in that regard or don't change anything at all.