Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Expose FriendlyException on play command #3085

Merged
merged 2 commits into from Nov 6, 2019
Merged

[Audio] Expose FriendlyException on play command #3085

merged 2 commits into from Nov 6, 2019

Conversation

aikaterna
Copy link
Member

@aikaterna aikaterna commented Oct 25, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This change will expose the Lavalink.jar FriendlyException text to the users when they use the play command and the resulting request is a broken video: on YouTube this could be region locked videos, copyright claims by the original owners, etc. Provides a bit more information to the user besides just "Nothing found."

@aikaterna aikaterna requested a review from Twentysix26 as a code owner Oct 25, 2019
@Flame442 Flame442 added the Type: Enhancement label Oct 26, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Nov 6, 2019
@mikeshardmind mikeshardmind merged commit d85fb26 into Cog-Creators:V3/develop Nov 6, 2019
1 check passed
@aikaterna aikaterna deleted the patch-1 branch Nov 6, 2019
@Drapersniper Drapersniper mentioned this pull request Nov 7, 2019
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants