Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License info command #3090

Merged
merged 6 commits into from Nov 9, 2019
Merged

License info command #3090

merged 6 commits into from Nov 9, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Oct 27, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This works on some things we've had in discussion in discord. It's merely putting the technical parts of this forward for now. More is needed on this still.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Oct 27, 2019
@Flame442 Flame442 added the Type: Feature label Oct 27, 2019
@Kowlin
Copy link
Member

@Kowlin Kowlin commented Nov 4, 2019

What we may wanna do in terms of listing is directly show the LICENCE.md in GitHub, as it does go out of its way to be more user friendly with an more human readable blurb on the top, which we wouldn't have to maintain or verify that it complies with the license.

@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Nov 4, 2019

This does link to that. The problem is that all of the other licenses which we lean on will not fit in a single message, so we need to find a good way to show those to users.

@mikeshardmind mikeshardmind marked this pull request as ready for review Nov 6, 2019
@Flame442 Flame442 self-assigned this Nov 8, 2019
Kowlin
Kowlin previously approved these changes Nov 8, 2019
Kowlin
Kowlin previously approved these changes Nov 8, 2019
Kowlin
Kowlin approved these changes Nov 9, 2019
@mikeshardmind mikeshardmind merged commit 6852b7a into Cog-Creators:V3/develop Nov 9, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the license-info branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants