Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add deprecation warnings about removal of shared libraries. #3106

Merged

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Nov 9, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR:

  • adds deprecation note about shared libraries in Downloader Framework docs
  • makes bot send deprecation warning when using [p]load and [p]reload commands if the repos loaded cogs are from have shared libraries (only works with Downloader loaded)
  • makes bot send deprecation warning when using install and update commands if the repos installed/updated cogs are from have shared libraries
  • makes bot print deprecation warning when some package tries importing from cog_shared.* (sadly only works for the first time the import of specific shared lib happens)

Soo, there are 3 deprecation warnings in different places, I think each of them is worth having but if you think some isn't, I can revert it.

@jack1142 jack1142 force-pushed the V3/deprecate_shared_libs branch 2 times, most recently from 43ee699 to dca2316 Compare Nov 9, 2019
@jack1142 jack1142 marked this pull request as ready for review Nov 10, 2019
@jack1142
Copy link
Member Author

@jack1142 jack1142 commented Nov 10, 2019

This is now ready for review. I updated the PR's description with the made changes.

@jack1142 jack1142 force-pushed the V3/deprecate_shared_libs branch from 716590e to 84d1069 Compare Nov 10, 2019
@Flame442 Flame442 added the Type: Enhancement label Nov 12, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Nov 14, 2019
@mikeshardmind mikeshardmind added the Release Blocker label Nov 26, 2019
@jack1142 jack1142 force-pushed the V3/deprecate_shared_libs branch from 9897f41 to 237e2fb Compare Dec 19, 2019
@mikeshardmind mikeshardmind merged commit b457f8d into Cog-Creators:V3/develop Dec 20, 2019
1 check passed
@jack1142 jack1142 deleted the V3/deprecate_shared_libs branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants