Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add [p]listdisabled command #3118

Merged
merged 7 commits into from Nov 22, 2019
Merged

Conversation

PredaaA
Copy link
Member

@PredaaA PredaaA commented Nov 13, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR adds a command to list disabled commands. By default it will send global entries, but it's also possible to get guild disabled commands.

Closes #3094.

@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Nov 14, 2019

After some discussion with @Flame442 about this PR, I will make this command respect the same format as [p]command disable/enable commands with using subcommands global and server to specify the scope to check, instead of using a bool in a simple command.
I will change this tomorrow.

@Flame442 Flame442 added the Type: Feature label Nov 14, 2019
@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Nov 15, 2019

I just updated the PR to make it as the same format as [p]command disable/enable commands.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Nov 15, 2019
@Flame442 Flame442 self-assigned this Nov 22, 2019
redbot/core/core_commands.py Outdated Show resolved Hide resolved
redbot/core/core_commands.py Show resolved Hide resolved
redbot/core/core_commands.py Outdated Show resolved Hide resolved
redbot/core/core_commands.py Show resolved Hide resolved
redbot/core/core_commands.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Changes requested by Flame#2941

@Flame442 Flame442 added the QA: Changes Requested label Nov 22, 2019
@PredaaA
Copy link
Member Author

@PredaaA PredaaA commented Nov 22, 2019

Last commit resolves all @Flame442 requested changes. (Thanks for the help Flame)

@Flame442 Flame442 added QA: Passed and removed QA: Changes Requested labels Nov 22, 2019
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@mikeshardmind mikeshardmind merged commit 7774217 into Cog-Creators:V3/develop Nov 22, 2019
1 check passed
@PredaaA PredaaA deleted the patch-7 branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants