Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased clarity of wording in info command #3121

Merged
merged 4 commits into from Nov 14, 2019
Merged

Increased clarity of wording in info command #3121

merged 4 commits into from Nov 14, 2019

Conversation

Vexed01
Copy link
Contributor

@Vexed01 Vexed01 commented Nov 14, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Draper's variation of ClearlyElevated's origianal suggestion in #feature-ideas, Discord.
Replaces "This is an..." with "Example Bot Username is an...".
Possible variation: use the bot's nick instead of name.

@Vexed01 Vexed01 requested a review from tekulvw as a code owner Nov 14, 2019
@Vexed01 Vexed01 requested a review from Twentysix26 as a code owner Nov 14, 2019
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Nov 14, 2019

I don't think this message should change in this manner. At most, it should change from

This is an instance ...

to

This bot is an instance ...

There's no need to format in a bot's name, and depending on a bot's name could actually make the text less clear

If people would like to elaborate about their bot, that is exactly the purpose of the custominfo setting. This section is not about their bot, but about Red.

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

👍 Thanks for the quick follow up on this. I do agree that adding that one word actually makes it clearer even with my disagreement on formatting in the bot's name here.

@mikeshardmind mikeshardmind changed the title Use the bot's username in [p]info instead of "This..." Increased clarity of wording in info command Nov 14, 2019
@mikeshardmind mikeshardmind merged commit 6aeca83 into Cog-Creators:V3/develop Nov 14, 2019
1 check passed
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Nov 14, 2019
@Vexed01 Vexed01 deleted the patch-10 branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants