Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes errors on repo add from empty string values for install_msg #3153

Merged
merged 2 commits into from Dec 2, 2019
Merged

Conversation

Flame442
Copy link
Member

@Flame442 Flame442 commented Nov 25, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes an issue when the value of install_msg was set to an empty string value (such as ""), causing it to not be None. Attempting to send this empty string in discord would throw an error. There probably needs to be more checks to the install messages to prevent errors (2k chars, etc), but this PR does not handle that.

@Flame442 Flame442 requested a review from Twentysix26 as a code owner Nov 25, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Nov 26, 2019
@mikeshardmind mikeshardmind added the Release Blocker label Nov 26, 2019
@mikeshardmind mikeshardmind merged commit d07e718 into Cog-Creators:V3/develop Dec 2, 2019
1 check passed
@Flame442 Flame442 deleted the patch-1 branch Dec 2, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants