Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes errors on repo add from empty string values for `install_msg` #3153
+2
−1
Conversation
mikeshardmind
merged commit d07e718
into
Cog-Creators:V3/develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Flame442 commentedNov 25, 2019
Type
Description of the changes
Fixes an issue when the value of
install_msgwas set to an empty string value (such as ""), causing it to not beNone. Attempting to send this empty string in discord would throw an error. There probably needs to be more checks to the install messages to prevent errors (2k chars, etc), but this PR does not handle that.