Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloader] Ensure consistent output from git commands #3160

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Nov 29, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Git support localisation so output may vary by language causing parsing to fail.
This PR ensures that git will always use English for output.

// note: I actually haven't been able to run git in non-English language and this fix is based solely on what I've seen in git's source (and gettext's manual).
okay, I've managed to run git in non-English language, I didn't install language pack 馃槃

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 8, 2019
@mikeshardmind mikeshardmind merged commit 6720507 into Cog-Creators:V3/develop Dec 8, 2019
1 check passed
@jack1142 jack1142 deleted the V3/ensure_consistent_git_output branch Dec 8, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants