Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Better error handling after multiple subsequential errors #3165

Closed
wants to merge 21 commits into from
Closed

[Audio] Better error handling after multiple subsequential errors #3165

wants to merge 21 commits into from

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Dec 3, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Auto disconnects the player if there are more than 5 errors in the last 10 seconds. (Likely caused by ... YouTube or playing local album with broken tracks etc)

Benefit of this is to reduce message spam caused by the bot when letting them know the playback broke

Also while at it fixed 1 bug where the DJ command was crashing

Drapersniper added 2 commits Dec 3, 2019
…ordBot into refactoring

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>

# Conflicts:
#	redbot/cogs/audio/audio.py
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper Drapersniper requested a review from Twentysix26 as a code owner Dec 3, 2019
@Flame442 Flame442 added Type: Enhancement Type: Fix labels Dec 3, 2019
Drapersniper and others added 7 commits Dec 3, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
… a valid work around discord ratelimits caused by the spam
PredaaA
PredaaA previously approved these changes Dec 4, 2019
Copy link
Member

@PredaaA PredaaA left a comment

I tested this PR and works as intended.

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Drapersniper added 3 commits Dec 4, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
1 Migrate Config to Schema 3 without playlists
and update get_playlist methods

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
…thout playlists and update get_playlist methods"

This reverts commit 4af33cf

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 19, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper Drapersniper mentioned this pull request Dec 19, 2019
39 tasks
mikeshardmind
mikeshardmind previously approved these changes Dec 20, 2019
@mikeshardmind mikeshardmind self-requested a review Dec 20, 2019
@mikeshardmind mikeshardmind dismissed their stale review Dec 20, 2019

Check conflict details after fixed.

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Dec 20, 2019

Needs conflict resolution.

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 20, 2019

Conflicts resolved

redbot/cogs/audio/audio.py Outdated Show resolved Hide resolved
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 21, 2019

Do not merge this one ... Merge #3205

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 22, 2019

Will setup a CPR for all of this so itsd easier to follow ... less likely to fuck up)

@Drapersniper Drapersniper deleted the f-yu-tube branch Dec 22, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants