Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Use instance name in default data path #3171

Merged

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Dec 5, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • instance names can now only include characters A-z, numbers, underscores, and hyphens - this isn't strictly required - we could have checks for invalid characters in Windows folder names, but supporting all sorts of characters could possibly be troublesome in other cases too
  • redbot-setup will now use instance name in default data path to avoid creating second instance with same data path - the new datapath should typically (everything before Red-DiscordBot is dependent on what appdirs gives us as it was before) be as follows:
    • Mac OS X: ~/Library/Application Support/Red-DiscordBot/data/<instance_name>
    • Unix: ~/.local/share/Red-DiscordBot/data/<instance_name>
    • Win: C:\Users\<username>\AppData\Local\Red-DiscordBot\Red-DiscordBot\data\<instance_name>
  • redbot-setup and redbot --edit should now gracefully handle invalid folder names for data path
  • few small changes in ``redbot --edit` (consistency)

@Flame442 Flame442 added the Type: Enhancement label Dec 6, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 28, 2019
@mikeshardmind mikeshardmind merged commit f3e7c20 into Cog-Creators:V3/develop Jan 2, 2020
1 check passed
@jack1142 jack1142 deleted the V3/unique_default_data_path branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants