Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Say no to busylooping :Awesome: #3176

Merged
merged 4 commits into from Dec 10, 2019
Merged

[Audio] Say no to busylooping :Awesome: #3176

merged 4 commits into from Dec 10, 2019

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Dec 8, 2019

Signed-off-by: Drapersniper 27962761+drapersniper@users.noreply.github.com

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes an infinite loop that could happen if the botowner blacklist an specific service (YouTube for example)

Drapersniper added 2 commits Dec 8, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper Drapersniper requested a review from Twentysix26 as a code owner Dec 8, 2019
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 8, 2019

Note for QA:

To reproduce this just add an youtube playlist

  1. [p]playlist save url

Then blacklist youtube
2. [p]audioset restrictions blacklist add youtube

set the playlist in step 1 as default autoplay playlist
3. [p]audioset autoplay playlist playlist_name_id

Then run
4. [p]autoplay

PredaaA
PredaaA previously approved these changes Dec 8, 2019
Copy link
Member

@PredaaA PredaaA left a comment

Tested and works as intended.

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@mikeshardmind mikeshardmind added the Release Blocker label Dec 8, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 8, 2019
@mikeshardmind mikeshardmind merged commit c67b6cd into Cog-Creators:V3/develop Dec 10, 2019
1 check passed
@Drapersniper Drapersniper deleted the say-no-to-busylooping branch Dec 22, 2019
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants