Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove API Reference for downloader, add page about publishing cogs #3234

Merged

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Dec 30, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

https://jack1142-red-prs.readthedocs.io/en/v3-remove_downloader_reference/guide_publish_cogs.html

Due to changes to our version guarantees and privatization, we shouldn't encourage users to use Downloader's API as it isn't guaranteed to stay this way.

This also adds a "Publishing cogs for V3" document explaining how to make user's cogs work with Downloader.

Took some parts from RJM's docs, so added him as co-author.

Co-authored-by: Redjumpman <Redjumpman@users.noreply.github.com>
@Flame442 Flame442 added Type: Enhancement Changelog Entry: Pending labels Dec 30, 2019
@jack1142 jack1142 marked this pull request as ready for review Dec 30, 2019
@jack1142
Copy link
Member Author

@jack1142 jack1142 commented Dec 30, 2019

This should now be ready for review.

@Flame442 Flame442 removed the Changelog Entry: Pending label Dec 31, 2019
@jack1142
Copy link
Member Author

@jack1142 jack1142 commented Jan 2, 2020

Now, this is truly ready for review...

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

LGTM

@mikeshardmind mikeshardmind added the Category: Docs label Jan 2, 2020
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 2, 2020
@mikeshardmind mikeshardmind merged commit debed50 into Cog-Creators:V3/develop Jan 2, 2020
2 checks passed
@jack1142 jack1142 deleted the V3/remove_downloader_reference branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants