Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utils] Privatize internal utils #3240

Merged

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Dec 30, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

@jack1142 jack1142 force-pushed the V3/privatize_some_utils branch from 34ba413 to 48484b0 Compare Dec 30, 2019
@Flame442 Flame442 added the Type: Enhancement label Dec 30, 2019
mikeshardmind
mikeshardmind previously approved these changes Jan 2, 2020
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

We will still need to do a final pass before release to make sure nothing's been missed, but this is progress towards the more formal version guarantees from 3.2 forward, +1

@mikeshardmind mikeshardmind dismissed their stale review Jan 2, 2020

annnnd it's conflicting.

Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

👍

@mikeshardmind mikeshardmind merged commit ab747d2 into Cog-Creators:V3/develop Jan 2, 2020
2 checks passed
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 2, 2020
@jack1142 jack1142 deleted the V3/privatize_some_utils branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants