Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed pagination fixing (pt2) #3248

Merged
merged 4 commits into from Jan 9, 2020
Merged

Embed pagination fixing (pt2) #3248

merged 4 commits into from Jan 9, 2020

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jan 1, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes buggy first embed of paginated help CC: @jack1142

@jack1142
Copy link
Member

@jack1142 jack1142 commented Jan 1, 2020

This PR doesn't fully address the problem, output of [p]permissions still gives empty page:
image

@mikeshardmind mikeshardmind changed the title I hate embeds Embed pagination fixing (pt2) Jan 2, 2020
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 2, 2020

Note with the above, this particular case isn't actually broken, but it might appear so to users. We may want to reconsider the embed generation strategy more later on.

@jack1142
Copy link
Member

@jack1142 jack1142 commented Jan 4, 2020

In my opinion, we should split "Commands" fields so that some part of it is shown in first page and some is shown in next page with "Commands (continued)", same as we already do when commands in next pages don't fit in one embed.
chrome_2020-01-04_12-38-39

@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 4, 2020

That's actually not how we're splitting fields currently, though I understand why it can appear that way. This needs a larger overhaul than it will get prior to 3.2 with a more generalized embed paginator than what's currently in use.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 9, 2020
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 9, 2020

Long term we should resize fields, short term, we're not ever having an embed with no fields. This can't go over discord limits, but might exceed some page size settings.

Kowlin
Kowlin approved these changes Jan 9, 2020
Copy link
Member

@Kowlin Kowlin left a comment

Working as intended.

@Kowlin Kowlin merged commit ed3b4e5 into Cog-Creators:V3/develop Jan 9, 2020
2 checks passed
@mikeshardmind mikeshardmind deleted the help-omg-why branch Jan 9, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants