Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctx.clean_prefix for *new* discord behavior #3249

Merged
merged 2 commits into from Jan 4, 2020
Merged

Fix ctx.clean_prefix for *new* discord behavior #3249

merged 2 commits into from Jan 4, 2020

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jan 1, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Discord made all mentions with the new text boxes use the <@! format, instead of following the prior behavior of " ! is for telling the client to check a nickname for render"

This fixes ctx.clean_prefix which relied on them not changing that without warning.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Jan 1, 2020
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 2, 2020

Clarification: While both mention formats have been valid for ages, we made assumptions based on both old behavior and purpose of the varying formats that at least within the lifespan of a context this would be "correct enough", this change just makes it more overall correct.

@Flame442 Flame442 self-assigned this Jan 4, 2020
Copy link
Collaborator

@Cog-CreatorsBot Cog-CreatorsBot left a comment

Approved by Flame#2941

@Flame442 Flame442 added the QA: Passed label Jan 4, 2020
@mikeshardmind mikeshardmind merged commit 9ec78d1 into Cog-Creators:V3/develop Jan 4, 2020
1 check passed
@mikeshardmind mikeshardmind deleted the discord-why branch Jan 4, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants