Fix ctx.clean_prefix for *new* discord behavior #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sarcasm approaching dangerous levels
|
Clarification: While both mention formats have been valid for ages, we made assumptions based on both old behavior and purpose of the varying formats that at least within the lifespan of a context this would be "correct enough", this change just makes it more overall correct. |
Flame442
approved these changes
Jan 4, 2020
Flame442
added
the
QA: Passed
jack1142
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Type
Description of the changes
Discord made all mentions with the new text boxes use the
<@!format, instead of following the prior behavior of "!is for telling the client to check a nickname for render"This fixes ctx.clean_prefix which relied on them not changing that without warning.